Conversation
RuoqingHe
requested review from
jiangliu,
liuw,
rbradford and
sboeuf
as code owners
|
@RuoqingHe Can you please rebase this and update now that clippy issue is resolved |
RuoqingHe
force-pushed
the
update-zerocopy
branch
3 times, most recently
from
bfdf3a5 to
43243cc
Compare
|
@rbradford I'm not sure this is the correct way of doing this, please take a look 👀 |
rbradford
left a comment
rbradford
left a comment
There was a problem hiding this comment.
This seems to align with the upgrade guide in google/zerocopy#1680
src/sdt.rs
Outdated
| /// Write a value at the given offset | ||
| pub fn write<T: AsBytes>(&mut self, offset: usize, value: T) { | ||
| self.write_bytes(offset, value.as_bytes()) | ||
| pub fn write<T: IntoBytes + FromBytes>(&mut self, offset: usize, mut value: T) { |
There was a problem hiding this comment.
What's with this mut change? We don't change the contents of value do we?
There was a problem hiding this comment.
You are right, I was scratching my head while trying to understand the trait changes and made this mistake. I will fix this 👍
RuoqingHe
force-pushed
the
update-zerocopy
branch
from
43243cc to
2af67eb
Compare
rbradford
left a comment
rbradford
left a comment
There was a problem hiding this comment.
Looks good to me. @RuoqingHe Have you mocked up the CH changes, if any that are necessary for this?
That's what get me started to do this, I think we still need to align |
RuoqingHe
force-pushed
the
update-zerocopy
branch
2 times, most recently
from
eaef76d to
c145482
Compare
Manually bump zerocopy to 0.8.23 to unblock our downstream to upgrade zerocopy. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
force-pushed
the
update-zerocopy
branch
from
c145482 to
b33e929
Compare
rbradford
left a comment
rbradford
left a comment
There was a problem hiding this comment.
@timw-rivos Is this okay with you?
Probably fine, maybe it's time to update this dependency in our downstream as well |
3 participants
Summary of the PR
Manually bump zerocopy to 0.8.23 to unblock our downstream to upgrade zerocopy.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.